Make minimal game duration to treat game as ranked configurable, lower default 180 -> 90 #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r default 180 -> 90 Fixes #214. Relevant discussion in https://discord.com/channels/549281623154229250/855772061095559179/1210540660604538951
|
Tested to work. I played two matches on the integration server, resigned at 60s in one of them, resigned at 120s in the other. Both show up in https://server5.beyondallreason.info/teiserver/admin/matches/user/44674 (which does not take ratings into account), only the latter shows up in https://server5.beyondallreason.info/teiserver/admin/users/ratings/44674 (which does). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214.
Relevant discussion in
https://discord.com/channels/549281623154229250/855772061095559179/1210540660604538951
Basically, some 1v1 games do legitimately conclude before 3:00, notably 2:33 is a reported today timing to shut down a comm drop. Also tick/rover rushes. This keeps coming up on the discord. 90s should be pretty optimal. And if it isn't, well, it's now configurable so we can just change the duration :)
Tested to not blow up the site, not tested in-game yet.